Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Links are marked as visited after history was wiped #1600

Closed
reisub-de opened this issue Oct 30, 2017 · 14 comments
Closed

Links are marked as visited after history was wiped #1600

reisub-de opened this issue Oct 30, 2017 · 14 comments

Comments

@reisub-de
Copy link

reisub-de commented Oct 30, 2017

#322 is where this issue was discussed previously. There doesn't seem to be much action in the Chromium bug we filed. 

Platform:

  • Android 7.1.2 LineageOs 14.1-201710010-NIGHTLY-piccolo
  • Firefox Focus (Klar) version 2.2

To reproduce:

  • visit any website which has a separate style for visited links (or the default style), e.g. https://gcc.gnu.org
  • close Firefox Focus and wipe the history
  • open Firefox Focus and visit the last domain
  • all links visited in the previous session have the visited style applied

Expected behavior: links visited in the last session should be styled normally

Workaround: close Firefox Focus in the recent-app view

@reisub-de reisub-de changed the title Links are marked as visited after history was wiped/focus was restarted Links are marked as visited after history was wiped Oct 30, 2017
@reisub-de
Copy link
Author

Could also reproduce this in the master branch

@pocmo
Copy link
Contributor

pocmo commented Oct 30, 2017

Related:

Semi-related:

@bbinto bbinto added the P2 label Oct 31, 2017
@bbinto bbinto added this to the Focus Android V4.0 milestone Nov 16, 2017
@bbinto
Copy link
Contributor

bbinto commented Nov 20, 2017

From another user.
Go to say the bbc news page

  • http://www.bbc.com/news/business
  • Open some links from the page into new tabs and view them
  • Clear the Firefox Focus cache at the end of session
  • Start Firefox focus with the bbc news page - previously viewed links are now grayed out.

If you Stop Firefox Focus and clear the Android Cache, then everything is clean.

Tested on:
Android 7 on a Lenovo Tablet 4 8 plus
Android 5.1 OPPO R7S phone
Android 6 Motorola Moto G Gen 2

and seems to not have happened before 2.3


Copying over another report from @doublez13 on #1392 for duping:
Open Firefox Focus
Go to wiki.kernel.org
Tap the rt link (first link on the list)
Tap trash can
Go to wiki.kernel.org
rt link still appears purple

Google Pixel running Android 8.0.0

Browser user agent if you go to this URL: http://www.whoishostingthis.com/tools/user-agent/
Mozilla/5.0 (Linux; Android 8.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Focus/2.0 Chrome/61.0.3163.98 Mobile Safari/537.36

@liuche
Copy link
Contributor

liuche commented Nov 30, 2017

Copying over comments from #1392 and duping that bug to this one (there are some commits linked to #1392 though).

@mcomella mcomella self-assigned this Dec 1, 2017
@Sdaswani Sdaswani modified the milestones: Focus Android V4.0, Focus Android V4.1 Dec 2, 2017
@Sdaswani
Copy link

Sdaswani commented Dec 2, 2017

this can move out to 4.1.

@mcomella mcomella removed their assignment Dec 6, 2017
@bbinto
Copy link
Contributor

bbinto commented Feb 16, 2018

Re-surfacing for triage after Focus release changes

@vesta0
Copy link
Collaborator

vesta0 commented Dec 18, 2018

I believe this was fixed. Need QA to verify.

@vesta0 vesta0 closed this as completed Dec 18, 2018
@vesta0 vesta0 added the QAReady flag for test read & needed label Dec 18, 2018
@doublez13
Copy link

Still valid on 7.0.13

Go to wiki.kernel.org
Tap the rt link (first link on the list)
Tap trash can
Go to wiki.kernel.org
rt link still appears purple

@vesta0
Copy link
Collaborator

vesta0 commented Jan 4, 2019

@sv-ohorvath can we confirm this was fixed in 8.0.5? Thanks!

@doublez13
Copy link

Nope. Visited links still appear purple after tapping the trash can on 8.0.5.

Go to wiki.kernel.org
Tap any link on the list.
Tap trash can
Go to wiki.kernel.org
Link still appears purple

@sv-ohorvath
Copy link
Contributor

I confirm it's still reproducing on 8.0.5, but only on webView.
After links are visited, they appear as visited after:

  • clearing history and going back to wiki.kernel.org or bbc.com/news
  • not clearing history, close & reopen the browser, opening the page again (wiki.kernel.org or bbc.com/news).
    devices: Samsung Galaxy S8 (Android 8.0), Huawei P9 Lite (Android 6.0)

@sv-ohorvath sv-ohorvath reopened this Jan 7, 2019
@sv-ohorvath sv-ohorvath added bug and removed QAReady flag for test read & needed labels Jan 7, 2019
@Sdaswani Sdaswani added this to the v9.0 Release milestone Jan 7, 2019
@vesta0 vesta0 modified the milestones: v9.0 Release, Backlog (P2, P3) Jan 11, 2019
@albell
Copy link

albell commented Jan 14, 2019

Confirmed happening on:

  • Android version: 8.0.0
  • Focus version: 7.0.13

This is deeply concerning it shows that my browsing history is in fact being stored somewhere locally (the Android cache?), and the whole promise of Focus is that sort of thing isn't supposed to happen.

I just tested and private windows in Firefox don't have this issue. Focus should be more private than a regular FF private window, not less! I've been waiting and waiting for this to get fixed. I was hoping the move to Gecko would resolve it. I know there are lots of issues, but as a user I would love to see this escalated. Thanks.

@vesta0
Copy link
Collaborator

vesta0 commented Jan 14, 2019

@albell thanks for your feedback. This is a WebView only bug and does not happen in GeckoView (which is why you can't reproduce it in a Firefox private window). Focus version 7.0.13 is still on WebView but we are currently doing a slow roll out of GeckoView on Focus 8.0 so you will see this resolved soon. All the best!

@pocmo
Copy link
Contributor

pocmo commented Jan 15, 2019

This is deeply concerning it shows that my browsing history is in fact being stored somewhere locally (the Android cache?), and the whole promise of Focus is that sort of thing isn't supposed to happen.

And to clarify: The data about what links have been visited by WebView is kept in memory longer than we would like to. However it is not stored permanently. WebView bug report.

@kbrosnan kbrosnan closed this as completed Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests