Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

CSS workaround for visited links not working on google.com & reddit.com #828

Closed
pocmo opened this issue Jun 28, 2017 · 11 comments
Closed

CSS workaround for visited links not working on google.com & reddit.com #828

pocmo opened this issue Jun 28, 2017 · 11 comments
Assignees
Labels
Milestone

Comments

@pocmo
Copy link
Contributor

pocmo commented Jun 28, 2017

No description provided.

@mcomella
Copy link
Contributor

This also happens on reddit: go to reddit, click a post on the home page, hit trash can, go to reddit, post is unexpectedly highlighted.

@mcomella mcomella changed the title CSS workaround for visited links not working on google.com CSS workaround for visited links not working on google.com & reddit.com Jul 10, 2017
@pocmo
Copy link
Contributor Author

pocmo commented Jul 13, 2017

I can't reproduce this on google.com anymore. I created a test page and can see that we are still removing the "visited" CSS styling in all builds - including the release build.

@rtanglao
Copy link

i can reproduce on google.ca: see

  1. https://www.flickr.com/photos/roland/35991445365/in/datetaken/
  2. https://www.flickr.com/photos/roland/35991445385/in/datetaken/ (after clearing history this shows the bug))

@pocmo
Copy link
Contributor Author

pocmo commented Jul 24, 2017

For everyone who can reproduce this. Please try this:

@mcomella
Copy link
Contributor

Is the link red (has been visited before) or blue (Not visited)?

The link is blue (not visited).

@ioana-chiorean
Copy link

confirming too - blue 🔵

@pocmo
Copy link
Contributor Author

pocmo commented Jul 25, 2017

This means the workaround in general is working on your devices. Can you post device model and Android version too?
And you can consistently reproduce this on google.com and reddit.com?

@mcomella
Copy link
Contributor

For reddit.com, I can reproduce on:

  • GS5, Andy 6.0.1
  • N5, 6.0.1

@pocmo
Copy link
Contributor Author

pocmo commented Aug 24, 2017

After disabling (and removing updates from) the System WebView APK I can see this issue on a test device now too. Maybe I can see why our workaround is not working now.

@pocmo
Copy link
Contributor Author

pocmo commented Aug 24, 2017

chromium I [INFO:CONSOLE(1)] "Uncaught SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode", source: (1)

Using "var" instead of "let" fixes the workaround on those devices. :)

@pocmo pocmo added this to the Cobalt* milestone Aug 24, 2017
@pocmo pocmo self-assigned this Aug 24, 2017
pocmo added a commit that referenced this issue Aug 24, 2017
On some older versions of WebView/Chrome this is a syntax error and our workaround
will not get executed.
pocmo added a commit that referenced this issue Aug 24, 2017
On some older versions of WebView/Chrome this is a syntax error and our workaround
will not get executed.
pocmo added a commit that referenced this issue Aug 24, 2017
On some older versions of WebView/Chrome this is a syntax error and our workaround
will not get executed.
@pocmo pocmo closed this as completed Aug 28, 2017
@nojunpark
Copy link

@pocmo I think I still see the issue on reddit.com. (FocusWebKitDebug build on Nexus 5X simulator with API 23/25) I click a reddit thread, then clear history and revisit to see the visited links marked. Same thing if I close the app via recent apps list, and restart the app. Did I understand the bug correctly?

screen shot 2017-08-28 at 12 07 04 pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants