Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

some translated locales still displays in English ('id', 'nl') #163

Closed
nojunpark opened this issue Mar 6, 2017 · 6 comments
Closed

some translated locales still displays in English ('id', 'nl') #163

nojunpark opened this issue Mar 6, 2017 · 6 comments
Milestone

Comments

@nojunpark
Copy link

nojunpark commented Mar 6, 2017

After setting the locale to 'id' (Bahasa Indonesia I believe), the Focus app still displays menus in English. I also tried in Bahasa Melayu, but shows in English as well. Tried both on simulator and Experia Z3C with marshmallow. (Tried both manually and using screengrab)

browserviewmenu_1488815180187

@nojunpark nojunpark changed the title 'id' locale still displays in English some translated locales still displays in English ('id', 'nl') Mar 7, 2017
@nojunpark
Copy link
Author

nojunpark commented Mar 7, 2017

Just found 'nl' also shows some locales in english as well. it looks like perhaps not all locales that are marked as 100% in https://l10n.mozilla-community.org/webstatus/?product=focus-android are fully localized.

@tomer
Copy link
Contributor

tomer commented Mar 7, 2017

Hebrew is missing as well. It is 100% translated on Pontoon, and the generated screenshots show the strings in English. (But featuring an Hebrew keyboard layout…)

Locale code he everywhere but iw on Java/Android.

@ahunt
Copy link
Contributor

ahunt commented Mar 8, 2017

I'd filed #186 to fix the locale mappings (which would fix Hebrew, i.e. iw/he), but I then realised that Indonesian (id/ih) is also one of the locales needing a mapping, i.e. my bug is a dupe.

Outdated mappings doesn't explain Bahasa Melayu though, that might need more investigation

@ahunt ahunt self-assigned this Mar 8, 2017
@ahunt ahunt added this to the Sprint 2 milestone Mar 8, 2017
ahunt added a commit that referenced this issue Mar 8, 2017
This should hopefully make Hebrew, Indonesian, and Yiddish all work.
@ahunt
Copy link
Contributor

ahunt commented Mar 8, 2017

Just found 'nl' also shows some locales in english as well. it looks like perhaps not all locales that are marked as 100% in https://l10n.mozilla-community.org/webstatus/?product=focus-android are fully localized.

I think for that we just need to do a new string import: values-nl/strings.xml in master only has 24-ish strings, whereas that dashboard states there are 37 strings.

// Edit: and the actual translation source also has all the first-run strings that the copy in focus-android master is missing, so it really looks like an update is all that's needed:
https://github.com/mozilla-l10n/focus-android-l10n/blob/master/locales/nl/app.po

ahunt added a commit that referenced this issue Mar 8, 2017
This should hopefully make Hebrew, Indonesian, and Yiddish all work.
ahunt added a commit that referenced this issue Mar 8, 2017
This should hopefully make Hebrew, Indonesian, and Yiddish all work.
nojunpark pushed a commit that referenced this issue Mar 9, 2017
This should hopefully make Hebrew, Indonesian, and Yiddish all work.
@pocmo pocmo removed this from the Sprint 2 milestone Mar 13, 2017
@pocmo
Copy link
Contributor

pocmo commented Mar 16, 2017

@npark-mozilla Is there any locale left that doesn't work (and has strings imported) or can this be closed?

@pocmo pocmo added the v1.0 label Mar 16, 2017
@pocmo
Copy link
Contributor

pocmo commented Mar 22, 2017

Looking at the latest screenshots 'nl' and 'id' show up correctly now.

@pocmo pocmo closed this as completed Mar 22, 2017
@pocmo pocmo modified the milestone: 1.0 Jul 26, 2017
@pocmo pocmo unassigned ahunt Jul 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants