-
Notifications
You must be signed in to change notification settings - Fork 712
some translated locales still displays in English ('id', 'nl') #163
Comments
Just found 'nl' also shows some locales in english as well. it looks like perhaps not all locales that are marked as 100% in https://l10n.mozilla-community.org/webstatus/?product=focus-android are fully localized. |
Hebrew is missing as well. It is 100% translated on Pontoon, and the generated screenshots show the strings in English. (But featuring an Hebrew keyboard layout…) Locale code |
I'd filed #186 to fix the locale mappings (which would fix Hebrew, i.e. iw/he), but I then realised that Indonesian (id/ih) is also one of the locales needing a mapping, i.e. my bug is a dupe. Outdated mappings doesn't explain Bahasa Melayu though, that might need more investigation |
This should hopefully make Hebrew, Indonesian, and Yiddish all work.
I think for that we just need to do a new string import: values-nl/strings.xml in master only has 24-ish strings, whereas that dashboard states there are 37 strings. // Edit: and the actual translation source also has all the first-run strings that the copy in focus-android master is missing, so it really looks like an update is all that's needed: |
This should hopefully make Hebrew, Indonesian, and Yiddish all work.
This should hopefully make Hebrew, Indonesian, and Yiddish all work.
This should hopefully make Hebrew, Indonesian, and Yiddish all work.
@npark-mozilla Is there any locale left that doesn't work (and has strings imported) or can this be closed? |
Looking at the latest screenshots 'nl' and 'id' show up correctly now. |
After setting the locale to 'id' (Bahasa Indonesia I believe), the Focus app still displays menus in English. I also tried in Bahasa Melayu, but shows in English as well. Tried both on simulator and Experia Z3C with marshmallow. (Tried both manually and using screengrab)
The text was updated successfully, but these errors were encountered: