Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Make search engine configurable #25

Closed
pocmo opened this issue Jan 26, 2017 · 2 comments
Closed

Make search engine configurable #25

pocmo opened this issue Jan 26, 2017 · 2 comments
Assignees
@pocmo @antlam
Labels
feature needs strings UX
Milestone
1.0

Comments

@pocmo
Copy link
Contributor

pocmo commented Jan 26, 2017

No description provided.

@pocmo pocmo added the feature label Jan 26, 2017
@pocmo pocmo mentioned this issue Feb 9, 2017
Closed
@pocmo pocmo added the UX label Feb 9, 2017
@pocmo pocmo added the v1.0 label Mar 7, 2017
@pocmo pocmo self-assigned this Mar 10, 2017
@pocmo
Copy link
Contributor Author

pocmo commented Mar 10, 2017

I'll take this and at least start to land some strings for the UI. The bigger chunk of work will be #184 - to support different configurations.

pocmo added a commit that referenced this issue Mar 10, 2017
@pocmo
Add setting for changing search engine. (#25)
453657b 
This is not functional yet. However with that patch we are landing the UI and strings already.
After importing the actual search engines (#184) we will know what values we actually want to
store in the preference.
pocmo added a commit that referenced this issue Mar 10, 2017
@pocmo
Add setting for changing search engine. (#25)
bbcc11f 
This is not functional yet. However with that patch we are landing the UI and strings already.
After importing the actual search engines (#184) we will know what values we actually want to
store in the preference.
pocmo added a commit that referenced this issue Mar 13, 2017
@pocmo
Add setting for changing search engine. (#25)
a54188d 
This is not functional yet. However with that patch we are landing the UI and strings already.
After importing the actual search engines (#184) we will know what values we actually want to
store in the preference.
@pocmo
Copy link
Contributor Author

pocmo commented Mar 13, 2017

Closing this one. The actual functionality will come with #184.

@pocmo pocmo closed this as completed Mar 13, 2017
@pocmo pocmo modified the milestone: 1.0 Jul 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

@antlam antlam

Labels
feature needs strings UX
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@pocmo @antlam