Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Two characters deleted in url bar on backspace #2835

Closed
mcomella opened this issue Jul 2, 2018 · 9 comments
Closed

Two characters deleted in url bar on backspace #2835

mcomella opened this issue Jul 2, 2018 · 9 comments
Labels
bug P3 testing meta label for all features/bugs requiring test

Comments

@mcomella
Copy link
Contributor

mcomella commented Jul 2, 2018

Steps to reproduce

  • Click url bar on home screen
  • Type "app"
  • Press backspace (autocomplete removed)
  • Press backspace

Expected behavior

"ap" remains

Actual behavior

"a" remains

Device information

  • Android device: Pixel 2
  • Focus version: Klar 5.2 #21731654
@mcomella mcomella added the bug label Jul 2, 2018
@pocmo
Copy link
Contributor

pocmo commented Jul 2, 2018

This looks like the same bug as: mozilla-mobile/android-components#348

Interestingly that's even in Fennec.

@codedsun
Copy link

codedsun commented Jul 3, 2018

@mcomella Is this issue up for grab?

@pocmo
Copy link
Contributor

pocmo commented Jul 3, 2018

@codedsun Yeah, but you will have to fix that in our android-components repository (ui-autocomplete module):
https://github.com/mozilla-mobile/android-components

@bbinto bbinto added this to the Backlog (P2, P3) milestone Jul 3, 2018
@codedsun
Copy link

codedsun commented Jul 3, 2018

@pocmo Let me check it, and I will try to resolve it :)👍

@codedsun
Copy link

codedsun commented Jul 3, 2018

@pocmo Wanted to ask that how can I debug the android autocomplete textview? Like I have cloned the app but wanted to know how this class is working through debugger. I have never debugged a library, can you guide me.
Thanks.

@ekager
Copy link
Contributor

ekager commented Jul 3, 2018

@codedsun there should be an example app that uses the autocomplete component.

@pocmo
Copy link
Contributor

pocmo commented Jul 4, 2018

Yeah, after importing the android-components project into Android Studio you should see multiple sample apps. The samples-toolbar is probably the easiest/simplest one for testing this component.

@rpappalax rpappalax added the testing meta label for all features/bugs requiring test label Aug 4, 2018
@vesta0
Copy link
Collaborator

vesta0 commented Oct 8, 2018

I just tried to recreate this and it seems to behave as expected. @rpappalax would you please confirm?

@mcomella
Copy link
Contributor Author

mcomella commented Oct 8, 2018

I fixed this in 0.26 components and Focus is using the latest components so it should no longer be an issue.

Components issue for this: mozilla-mobile/android-components#911

@mcomella mcomella closed this as completed Oct 8, 2018
@ghost ghost removed the blocked label Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug P3 testing meta label for all features/bugs requiring test
Projects
None yet
Development

No branches or pull requests

7 participants