Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Open in Firefox Focus from notifications bar keeps crashing #4289

Closed
ebalazs-sv opened this issue May 31, 2019 · 14 comments
Closed

Open in Firefox Focus from notifications bar keeps crashing #4289

ebalazs-sv opened this issue May 31, 2019 · 14 comments

Comments

@ebalazs-sv
Copy link

ebalazs-sv commented May 31, 2019

Steps to reproduce:

  1. Open Focus. Load a web page. Go to the Settings menu.
  2. Expand the notification from the notification bar and tap "Open".

Expected behavior
Firefox Focus should open on the settings menu screen.

Actual behavior
Firefox Focus keeps crashing message appears - video

Device information
Android device: OnePlus 5T (Android 9); Motorola Nexus 6 (Android 7.1.1)
Focus version: 8.0.12 GeckoView 68.0

Logcat

@droeh
Copy link
Contributor

droeh commented May 31, 2019

Does this reproduce reliably with those steps? I've tried a couple dozen times, both with a local build and the beta release, on both a physical phone (Pixel 2) and x86 emulator without seeing this happen a single time. This looks to be an issue where we're failing to release the display, but tracking down exactly how it happens is going to be difficult without being able to reproduce it on my end :/

@vesta0
Copy link
Collaborator

vesta0 commented May 31, 2019

I just tried on Pixel 3 and I can't reproduce it, mainly because the persistent notification is missing.

@ebalazs-sv
Copy link
Author

@droeh @vesta0 Hi!

I tested this on 8.0.12 GeckoView 68.0 with Google Pixel (Android 9) and it is not reproducible following the steps from my first comment.

This is reproducible on the devices: Samsung Galaxy S8 (Android 9), OnePlus 5T (Android 9); Motorola Nexus 6 (Android 7.1.1).

Thanks!

@colintheshots
Copy link
Contributor

colintheshots commented Jun 3, 2019

This is the Display Already Acquired crash. The solution is to avoid loading two browser fragments in any case even briefly as it'll crash GeckoView. We struggled with this same issue on Fenix.

@vesta0 vesta0 added the 8.1 label Jun 3, 2019
@vesta0 vesta0 removed the 8.1 label Aug 9, 2019
@kbrosnan
Copy link

I hit this looking for different crash for @droeh Looks like older versions of Android might be needed to hit this easily?

  • Open Focus and load a website
  • Open the 3 dot menu and select settings
  • Swipe down the notification shade and select open from the Focus notification

https://crash-stats.mozilla.org/report/index/10f74b7b-da73-43e2-9ca3-69a130200922
https://crash-stats.mozilla.org/report/index/139fae23-c848-45ea-b507-291fd0200922

@kbrosnan
Copy link

Might be a dupe of #4342 which has a PR

@sv-ohorvath
Copy link
Contributor

Still reproducing on Focus 8.8.4 (GV 81.0.2)

@lobontiumira
Copy link

I reproduced this crash on the 8.14.0 build with Samsung Galaxy Note 8 (Android 9).

@lobontiumira
Copy link

Reproducible on 8.15.1 build with Samsung Galaxy Note 8 (Android 9).

@lobontiumira
Copy link

Reproducible on 8.15.2 with Sony Xperia Z5 Premium (Android 7.1.1).

@ebalazs-sv
Copy link
Author

This issue is reproducible on Focus 8.15.3 GV 88 with Huawei P9 Lite (Android 7).

@lobontiumira
Copy link

I was not able to reproduce this issue on the 8.16.0 build with Google Pixel (Android 10), nor with Samsung Galaxy Note 8 (Android 9).

@lobontiumira
Copy link

Reproducible on 8.17.0 Focus build with Google Pixel (Android 10).

@lobontiumira
Copy link

I was not able to trigger the crash on the latest builds: RC 96.1.0, and 1/6 Focus Nightly with Google Pixel (Android 10).
I'll close this ticket.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants