Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Add "search" action into text selection menu of third-party apps #506

Closed
4 tasks done
pocmo opened this issue Apr 21, 2017 · 11 comments
Closed
4 tasks done

Add "search" action into text selection menu of third-party apps #506

pocmo opened this issue Apr 21, 2017 · 11 comments
Assignees
Milestone

Comments

@pocmo
Copy link
Contributor

pocmo commented Apr 21, 2017

Theme: Default Browser & Android Advantage

User Story

I want to quickly start a private Focus search from my homescreen

Feature

Include action in text selection menu.

Example

1 d4zzzplbtk5cen9qn0-cba

Technical details
https://medium.com/google-developers/custom-text-selection-actions-with-action-process-text-191f792d2999

Tasks

  • Implement text selection action receiver (ACTION_PROCESS_TEXT)
  • Trigger search from action
  • Update copy: "Search" / "Private Search" / "Focus Search" / ... ?
  • Add telemetry probe
@antlam
Copy link
Contributor

antlam commented Apr 21, 2017

If it's just adding a "SEARCH" item to the context menu/action bar here that triggers Firefox Focus, then we can just jump right into loading a URL in Firefox Focus after they press "SEARCH"

@pocmo pocmo self-assigned this Apr 24, 2017
@pocmo
Copy link
Contributor Author

pocmo commented Apr 24, 2017

In Firefox we add the product name: "Firefox search", "Nightly search", ... Should we do this here too? Focus search? Or maybe even Private search?

@antlam
Copy link
Contributor

antlam commented Apr 24, 2017

Maybe! but I worry that would seem out of guidelines for these context menu/action bars...

From my understanding, this SEARCH action is usually done by the default browser. So if Firefox Focus is my default, it seems unnecessary to call that out again in the menu.

Thoughts?

@pocmo
Copy link
Contributor Author

pocmo commented Apr 25, 2017

The action will show up always - independently from whether we are the default browser or not. For example in my case I see search entries for all my Firefoxes and Focus.

@pocmo
Copy link
Contributor Author

pocmo commented Apr 25, 2017

Thoughts?

Users might want to be sure that the action is launching their privacy browser that doesn't keep any history etc. - Launching the search in a different browser might mean that this search will be connected with your profile.

@antlam
Copy link
Contributor

antlam commented Apr 25, 2017

The action will show up always

Ah, my mistaken. Then this makes more sense if we label it explicitly.

@brampitoyo
Copy link

Some copy ideas other than the ones mentioned above:

  • Search with Firefox Focus (too long?)
  • Search with Focus

Otherwise, I like “Private Search”. Even though it’s less unique because it doesn’t contain our name, it communicates exactly what user expects: “When I tap on this, my search will not be recorded into history”.

@antlam
Copy link
Contributor

antlam commented May 15, 2017

@pocmo and I were also talking about "Focus Search" because of the system conventions (Google Search, Yahoo Search, etc)...

Thoughts @mheubusch ?

@pocmo
Copy link
Contributor Author

pocmo commented May 15, 2017

Search with Firefox Focus (too long?)
Search with Focus

They might be both too long. All other system text actions are single words or pretty short: Copy, Cut, Select All, Translate

@pocmo and I were also talking about "Focus Search" because of the system conventions (Google Search, Yahoo Search, etc)...

So far I have only seen Firefox adding the product name to the action: Firefox Search.

Otherwise, I like “Private Search”. Even though it’s less unique because it doesn’t contain our name, it communicates exactly what user expects

It turns out that "Private Search" is also much easier to implement than "Focus Search" which consists of dynamic product name (Focus, Klar) and a translated String (Search). This is not supported by Android and I will need to add some build system magic to make this possible.

@antlam
Copy link
Contributor

antlam commented May 15, 2017

"Search Privately" might make more sense here then?

@bbinto
Copy link
Contributor

bbinto commented May 29, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants