Build and target SDK 28 (9.0) Closes #2909 #3053
Conversation
There was a problem hiding this comment.
This generally looks good. The one exception is I normally get a bit nervous seeing so many activity!!. calls in fragments. There are only two callbacks in fragments where the activity is almost guaranteed to be there: onAttach and onActivityCreated. I think we've been lucky because our app doesn't get evicted due to running a foreground service mostly in a single activity or we'd have a lot more crashes. Approved.
colintheshots
force-pushed
the
target-28
branch
from
c7ac93a
to
fc3c69d
Compare
colintheshots
force-pushed
the
target-28
branch
from
fc3c69d
to
0ad032b
Compare
|
Do not merge this! This might be more serious than I thought. WebViews targeting API 28 do not allow accessing non-SSL URLs. This means most URLs fail outright, even if they're only going to redirect to an https URL. I haven't found a way to toggle allowing insecure URLs back on quite yet. |
|
False alert. It looks like adding android:usesCleartextTraffic="true" to the manifest works around it. I had tried almost everything involving the network security config XML. |
Sorry this is a lot, most of the changes are updating to use support library.