Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Long press on reload on iPad for desktop site is buggy #1393

Closed
sblatz opened this issue Sep 28, 2018 · 3 comments
Closed

Long press on reload on iPad for desktop site is buggy #1393

sblatz opened this issue Sep 28, 2018 · 3 comments
Labels
Bug 🐞

Comments

@sblatz
Copy link
Contributor

sblatz commented Sep 28, 2018

Steps to reproduce:

  1. Open a website on iPad
  2. Press and hold reload icon

Expected:
Request desktop site menu appears

Actual:
The URL is grabbed as if you're about to drag and drop

This can likely be fixed fairly easily by making the urlText box smaller!
@danielbogomazov
Copy link
Contributor

I can take a look at this bug if no one else is already

@oliviabrown9
Copy link
Contributor

@danielbogomazov Go for it!

@danielbogomazov danielbogomazov mentioned this issue Oct 5, 2018
Merged
sblatz pushed a commit that referenced this issue Oct 6, 2018
@danielbogomazov @sblatz
Fixes #1393: Fix URL Bar Long Press and Drag (#1416)
e76a1ba 
* Move UILongPressGestureRecognizer from URLBar to textAndLockContainer

* Move UIDragInteractionDelegate from BrowserViewController to URLBar
sblatz pushed a commit that referenced this issue Oct 8, 2018
@danielbogomazov @sblatz
Fixes #1393: Fix URL Bar Long Press and Drag (#1416)
e15ceb7 
* Move UILongPressGestureRecognizer from URLBar to textAndLockContainer

* Move UIDragInteractionDelegate from BrowserViewController to URLBar
sblatz pushed a commit that referenced this issue Oct 9, 2018
@danielbogomazov @sblatz
Fixes #1393: Fix URL Bar Long Press and Drag (#1416)
6816bc6 
* Move UILongPressGestureRecognizer from URLBar to textAndLockContainer

* Move UIDragInteractionDelegate from BrowserViewController to URLBar
@oliviabrown9
Copy link
Contributor

Closed with #1416.

sblatz pushed a commit that referenced this issue Oct 18, 2018
@danielbogomazov @sblatz
Fixes #1393: Fix URL Bar Long Press and Drag (#1416)
5c74228 
* Move UILongPressGestureRecognizer from URLBar to textAndLockContainer

* Move UIDragInteractionDelegate from BrowserViewController to URLBar
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this issue Feb 14, 2024
@danielbogomazov @sblatz
Fixes mozilla-mobile/focus-ios#1393: Fix URL Bar Long Press and Drag (m…
e987ffb 
…ozilla-mobile/focus-ios#1416)

* Move UILongPressGestureRecognizer from URLBar to textAndLockContainer

* Move UIDragInteractionDelegate from BrowserViewController to URLBar
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this issue Feb 20, 2024
@danielbogomazov @sblatz
[focus-ios] Fixes mozilla-mobile/focus-ios#1393: Fix URL Bar Long Pre…
37afb65 
…ss and Drag (mozilla-mobile/focus-ios#1416)

* Move UILongPressGestureRecognizer from URLBar to textAndLockContainer

* Move UIDragInteractionDelegate from BrowserViewController to URLBar
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug 🐞
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sblatz @danielbogomazov @oliviabrown9