Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #934: Move magic numbers to constants #1637

Merged
merged 1 commit into from Feb 10, 2019

Conversation

Projects
None yet
2 participants
@klymenkoo
Copy link
Contributor

klymenkoo commented Jan 25, 2019

This PR moves magic numbers from files into UIConstants fixing issue #934

@oliviabrown9
Copy link
Member

oliviabrown9 left a comment

Looks great! Thank you so much for working on this!

@oliviabrown9 oliviabrown9 merged commit f503228 into mozilla-mobile:master Feb 10, 2019

3 checks passed

buddybuild: Firefox Focus (iOS, Focus) Build succeeded
Details
codecov/patch 100% of diff hit (target 79.72%)
Details
codecov/project Absolute coverage decreased by -0.5% but relative coverage increased by +20.27% compared to 9149064
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.