Closes #31: Add lint for fields-only classes. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a lint to make sure that classes that only contain final fields have a protected or public constructor in the API so that external clients can mock these classes. It also checks that these classes are not final for test subclassing.
snorp
approved these changes
Nov 29, 2018
|
I'm ok with this, but it seems like it may be a little specific to our use case. Maybe it would be better suited as a rule in some other linter? |
Right now none of the lints actually stop you from updating the api file and ignoring them so I think it's fine to merge this as is. As discussed on slack, in the future we'll be able to select which lints run so that should ease your concern, opened Issue #34 for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lint to make sure that classes that only contain final fields have
a protected or public constructor in the API so that external clients can mock
these classes. It also checks that these classes are not final for test
subclassing.