PGIOS51 Add Onboarding Screens #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… screens using a UIPageViewController
…ler using a Page struct and a helper setupPages function to set the before and after on the list Move the UIPageViewControllerDataSource and UIPageViewControllerDelegate protocols into extensions on CarouselPageViewDataSource
…ntroller for now May change it back to NavgationCoordinaror later
… CarouselPageViewDataSource to self Add currentIndex to keep track of the index for the datasource function `presentationIndex(for pageViewController: UIPageViewController)`
…cator and skip button
…f the right bar button
…rivate lazy vars so they are only created once
Refactor using the UI components that are instantiates as lazy vars
Add isLastPage isLastPageNext and shouldHideControls booleans to help determine when to show and hide the skip button and page indicator Refactor the skipButton(isHidden: Bool) function to reformatPage() that uses the computed booleans to determines how to reformat the view When skipping to the last page, update the currentIndex to the last page
…pendingIndex and calls reformatPage
…es, it updates the currentIndex and pageControl index and then sets the pendingIndex to nil and calls reformatPage()
…e get started button is selected it will navigate to the login screen Set the button title for the last onboarding screen
…nd set as .landing when type is .landing
When don't want to show the buttons, hide the stackView When want only the getStarted button to show on the last onboarding screen, remove the other button from the stackView and increase the distance of the stack view bottom to the safe area bottom
FirefoxPrivateNetworkVPN/ViewControllers/CarouselPageViewController.swift
Outdated
Show resolved
Hide resolved
FirefoxPrivateNetworkVPN/ViewControllers/CarouselPageViewController.swift
Show resolved
Hide resolved
FirefoxPrivateNetworkVPN/ViewControllers/CarouselDataSource.swift
Outdated
Show resolved
Hide resolved
FirefoxPrivateNetworkVPN/ViewControllers/CarouselDataSource.swift
Outdated
Show resolved
Hide resolved
FirefoxPrivateNetworkVPN/ViewControllers/CarouselPageViewController.swift
Show resolved
Hide resolved
FirefoxPrivateNetworkVPN/ViewControllers/CarouselPageViewController.swift
Outdated
Show resolved
Hide resolved
Paul-Huang-Connected
approved these changes
Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting of the close button and skip button on CarouselPageViewController will be done in bugfix/PGIO-63