Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beetmover release triggers #4531

Closed
wants to merge 1 commit into from

Conversation

gabrielBusta
Copy link
Member

Description

Stop uploading release graph client builds to the Mozilla archive automatically.

cc @bakulf @ahal

Reference

#4341

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@gabrielBusta gabrielBusta self-assigned this Sep 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Base: 70.48% // Head: 28.81% // Decreases project coverage by -41.67% ⚠️

Coverage data is based on head (778d540) compared to base (996e53a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4531       +/-   ##
===========================================
- Coverage   70.48%   28.81%   -41.68%     
===========================================
  Files         255      252        -3     
  Lines       16009    14275     -1734     
  Branches     8104     8104               
===========================================
- Hits        11284     4113     -7171     
+ Misses       4323     4216      -107     
- Partials      402     5946     +5544     
Flag Coverage Δ
lottie_tests 56.33% <ø> (ø)
qml_tests 7.63% <ø> (ø)
unit_tests 27.96% <ø> (-43.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/unit/testaddonapi.cpp 6.66% <0.00%> (-93.34%) ⬇️
tests/unit/testandroidmigration.cpp 7.31% <0.00%> (-92.69%) ⬇️
tests/unit/testfeature.cpp 7.33% <0.00%> (-92.67%) ⬇️
tests/unit/testmodels.cpp 7.11% <0.00%> (-92.44%) ⬇️
tests/unit/testaddonindex.cpp 7.59% <0.00%> (-92.41%) ⬇️
tests/unit/testserveri18n.cpp 7.69% <0.00%> (-92.31%) ⬇️
tests/unit/testlicense.cpp 10.00% <0.00%> (-90.00%) ⬇️
tests/unit/testlocalizer.cpp 10.81% <0.00%> (-89.19%) ⬇️
tests/unit/testtimersingleshot.cpp 13.79% <0.00%> (-86.21%) ⬇️
tests/unit/testcomposer.cpp 13.97% <0.00%> (-86.03%) ⬇️
... and 159 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -37,7 +37,7 @@ tasks:
worker:
chain-of-trust: true
max-run-time: 1800
run-on-tasks-for: [github-release, action:release-promotion]
Copy link
Collaborator

@ahal ahal Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically we could leave the promote phase to be triggered on release creation, and then we'd only have a ship-client phase in the action. But that's a bit clunky.. Just calling it out in case the VPN team would prefer that though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants