Bump com.pinterest:ktlint from 0.48.2 to 0.51.0-FINAL in /android

[dependabot]

Bumps com.pinterest:ktlint from 0.48.2 to 0.51.0-FINAL.

Release notes

Sourced from com.pinterest:ktlint's releases.

0.50.0

Deprecation of ktlint-enable and ktlint-disable directives

The ktlint-disable and ktlint-enable directives are no longer supported. Ktlint rules can now only be suppressed using the @Suppress or @SuppressWarnings annotations. A new rule, internal:ktlint-suppression, is provided to replace the directives with annotations.

API consumers do not need to provide this rule, but it does no harm when done.

The internal:ktlint-suppression rule can not be disabled via the .editorconfig nor via @Suppress or @SuppressWarnings annotations.

Custom Rule Providers need to prepare for Kotlin 1.9

In Kotlin 1.9 the extension points of the embedded kotlin compiler will change. Ktlint only uses the org.jetbrains.kotlin.com.intellij.treeCopyHandler extension point. This extension is not yet supported in 1.9, neither is it documented (#KT-58704). Without this extension point it might happen that your custom rules will throw exceptions during runtime. See #1981.

In Ktlint, 7 out of 77 rules needed small and sometimes bigger changes to become independent of the extension point org.jetbrains.kotlin.com.intellij.treeCopyHandler. The impact on your custom rules may vary dependent on the way the autocorrect has been implemented. When manipulating ASTNodes there seems to be no impact. When, manipulating PsiElements, some functions consistently result in a runtime exception.

Based on the refactoring of the rules as provided by ktlint-ruleset-standard in Ktlint 0.49.x the suggested refactoring is as follows:

• Replace LeafElement.replaceWithText(String) with LeafElement.rawReplaceWithText(String).
• Replace PsiElement.addAfter(PsiElement, PsiElement) with AstNode.addChild(AstNode, AstNode). Note that this method inserts the new node (first) argument before the second argument node and as of that is not a simple replacement of the PsiElement.addAfter(PsiElement, PsiElement).
• Replace PsiElement.replace(PsiElement) with a sequence of AstNode.addChild(AstNode, AstNode) and AstNode.removeChild(AstNode).

Be aware that your custom rules might use other functions which also throw exceptions when the extension point org.jetbrains.kotlin.com.intellij.treeCopyHandler is no longer supported.

In order to help you to analyse and fix the problems with your custom rules, ktlint temporarily supports to disable the extension point org.jetbrains.kotlin.com.intellij.treeCopyHandler using a flag. This flag is available in the Ktlint CLI and in the KtlintRuleEngine. By default, the extension point is enabled like it was in previous versions of ktlint.

At least you should analyse the problems by running your test suits by running ktlint and disabling the extension point. Next you can start with fixing and releasing the updated rules. All rules in this version of ktlint have already been refactored and are not dependent on the extension point anymore. In Ktlint CLI the flag is to be activated with parameter --disable-kotlin-extension-point. API Consumers that use the KtlintRuleEngine directly, have to set property enableKotlinCompilerExtensionPoint to false.

At this point in time, it is not yet decided what the next steps will be. Ktlint might drop the support of the extension points entirely. Or, if the extension point org.jetbrains.kotlin.com.intellij.treeCopyHandler is fully supported at the time that ktlint will be based on kotlin 1.9 it might be kept. In either case, the flag will be dropped in a next version of ktlint.

Added

• Add new experimental rule binary-expression-wrapping. This rule wraps a binary expression in case the max line length is exceeded (#1940)
• Add flag to disable extension point org.jetbrains.kotlin.com.intellij.treeCopyHandler to analyse impact on custom rules #1981
• Add new experimental rule no-empty-file for all code styles. A kotlin (script) file may not be empty (#1074)
• Add new experimental rule statement-wrapping which ensures function, class, or other blocks statement body doesn't start or end at starting or ending braces of the block (#1938)
• Add new experimental rule blank-line-before-declaration. This rule requires a blank line before class, function or property declarations (#1939)
• Wrap multiple statements on same line wrapping (#1078)
• Add new rule ktlint-suppression to replace the ktlint-disable and ktlint-enable directives with annotations. This rule can not be disabled via the .editorconfig (#1947)
• Inform user about using --format option of KtLint CLI when finding a violation that can be autocorrected (#1071)

Removed

• Code which was deprecated in 0.49.x is removed. Consult changelog of 0.49.x` released for more information. Summary of removed code:

Fixed

• Do not flag a (potential) mutable extension property in case the getter is annotated or prefixed with a modifier property-naming (#2024)
• Do not merge an annotated expression body with the function signature even if it fits on a single line (#2043)
• Ignore property with name serialVersionUID in property-naming (#2045)
• Prevent incorrect reporting of violations in case a nullable function type reference exceeds the maximum line length parameter-list-wrapping (#1324)

... (truncated)

Changelog

Sourced from com.pinterest:ktlint's changelog.

Changelog

All notable changes to this project will be documented in this file. This project adheres to Semantic Versioning.

[1.3.1] - 2024-07-02

🔧 Fixes

• Add link for backing-property-naming, correct binary-expression-wrapping - #2704, by @​rsmith20
• Do not insert a whitespace element as first or last child inside a composite element - #2715, by @​paul-dingemans
• Do not rewrite a class to a single line signature in case it contains an EOL comment - #2716, by @​paul-dingemans
• Fix false positive when anonymous function is used as value argument - #2718, by @​paul-dingemans
• Fix suppression handling when 'formatter:on' not properly specified - #2719, by @​paul-dingemans
• Fix false positive when primary constructor has no arguments and a secondary constructor exists - #2717, by @​paul-dingemans
• Ignore suppressions for no-unused-imports rule - #2720, by @​paul-dingemans
• Ignore suppressions in rule no-unused-imports - #2725, by @​paul-dingemans
• Fix false alert Format was not able to resolve all violations which (theoretically) can be autocorrected - #2727, by @​paul-dingemans
• Fix "unset" value for property ktlint_chain_method_rule_force_multiline_when_chain_operator_count_greater_or_equal_than - #2728, by @​paul-dingemans

📦 Dependencies

• Update dependency gradle to v8.8 - #2680, by @​renovate[bot]
• Update plugin com.gradle.develocity to v3.17.5 - #2697, by @​renovate[bot]
• Update actions/checkout digest to 692973e - #2699, by @​renovate[bot]
• Update dependency io.github.hakky54:logcaptor to v2.9.3 - #2707, by @​renovate[bot]
• Update dependency org.junit.jupiter:junit-jupiter to v5.10.3 - #2721, by @​renovate[bot]

💬 Other

• Remove sdkman - #2693, by @​paul-dingemans

[1.3.0] - 2024-06-04

🆕 Features

• Support partial formatting - #2631, by @​paul-dingemans

• Suppress property-name rule for ObjectPropertyName or PrivatePropertyName - #2643, by @​paul-dingemans

• Let API Consumer decide whether a LintError has to be autocorrected, or not - #2671, by @​paul-dingemans

• Promote experimental rules to non-experimental - #2674, by @​paul-dingemans

  • backing-property-naming
  • binary-expression-wrapping
  • chain-method-continuation
  • class-signature
  • condition-wrapping
  • function-expression-body
  • function-literal
  • function-type-modifier-spacing
  • multiline-loop

... (truncated)

Commits

• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)