Simplify balrog implementation #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove data parsing and client side validation - clean-up function signatures - define new verification method signature
|
@g-k would appreciate a quick review of our balrog/* files to make sure I've used your new module correctly. |
birdsarah
commented
May 7, 2021
| return false | ||
| } | ||
| // Verify method does not verify the leaf cert subject, so we do it here. | ||
| certs, _ := contentsignature.ParseChain([]byte(x5u)) |
There was a problem hiding this comment.
ignoring the error because contentsignature.Verify already calls ParseChain.
birdsarah
commented
May 7, 2021
| @@ -174,111 +171,42 @@ bool Balrog::fetchSignature(NetworkRequest* initialRequest, | |||
| }); | |||
|
|
|||
| connect(x5uRequest, &NetworkRequest::requestCompleted, | |||
| [this, signatureBlob, algorithm, dataUpdate](const QByteArray& data) { | |||
| [this, signatureBlob, updateData](const QByteArray& x5uData) { | |||
There was a problem hiding this comment.
@bakulf as we discussed we leave the network request handling on cpp side.
bakulf
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #797, #798
Instead of rolling our own, we use the new verify module of the mozilla go package autograph (https://github.com/mozilla-services/autograph/).
This allows for simplification of both the api.go code and the update/balrog.cpp.
In addition, we also resolve the FVP-02-002 and FVP-02-003.
Note, we have verified that balrog algorithm is p384ecdsa which is supported by autograph module.
Thanks to @g-k for splitting out the verify module.