Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to make signing release builds easier for developers #44

Closed
mcomella opened this issue Dec 20, 2019 · 3 comments
Closed
Assignees

Comments

@mcomella
Copy link
Contributor

Post GA?

Why/User Benefit/User Problem

In order to use "release" build variants like forPerformanceTest, we have to do our own signing. However, it's non-trivial integrate release signing into the regular Android Studio build process: this bug is to make it easy.

Impact

Without this, setting up local performance builds is an annoyance: developers have to do something hacky like adding local signing configurations and remember not to check them into the tree.

Acceptance Criteria (how do I know when I’m done?)

  • It is easy for developers to create signed forPerformanceTest builds
  • Documentation (e.g. in README) is updated
  • Folks are notified of any changes to their workflow

Solution ideas:

  • We check a debug.keystore into the tree that signs forPerformanceTest builds and provide a signing config for it
  • Developers can specify a path to their debug.keystore and it will integrate the signing
  • Developers add custom run configs with signing in AS
@mcomella mcomella changed the title Figure out how to make release signing easier for developers Figure out how to make forPerformanceTest release signing easier for developers Dec 20, 2019
@mcomella
Copy link
Contributor Author

Can we just land the signingConfigs.debug line, as suggested in the wiki, in-tree? This would sign all forPerformanceTest builds with the debug keystore. This seems fine to me since we're not releasing the builds. We might have to update the TC configs though such that it no longer tries to sign forPerformanceTest builds with a release configuration.

@hawkinsw What do you think?

@hawkinsw
Copy link

Can we just land the signingConfigs.debug line, as suggested in the wiki, in-tree? This would sign all forPerformanceTest builds with the debug keystore. This seems fine to me since we're not releasing the builds. We might have to update the TC configs though such that it no longer tries to sign forPerformanceTest builds with a release configuration.

@hawkinsw What do you think?

Yes! I agree! That is, of course, with the caveat that I see no documentation anywhere about the validity of the signingConfigs object. That's not our problem -- just the sad state of the gradle Android build documentation, as far as I can tell. :-)

@mcomella mcomella changed the title Figure out how to make forPerformanceTest release signing easier for developers Figure out how to make signing release builds easier for developers Jul 9, 2020
@mcomella mcomella self-assigned this Jul 9, 2020
@mcomella
Copy link
Contributor Author

Addressed with mozilla-mobile/fenix#12438.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants