Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can i embed this inside webview? #1201

Open
fgroupindonesia opened this issue May 27, 2020 · 1 comment
Open

Can i embed this inside webview? #1201

fgroupindonesia opened this issue May 27, 2020 · 1 comment

Comments

@fgroupindonesia
Copy link

this is great! Especially when mozilla is under mobile (android) version.

I wish i could play flash player content as well using this feature.
And i wanted to know whether this is applicable to be implemented inside webview of android programatically?

Thanks in advanced!

Regards,
G

@fgroupindonesia fgroupindonesia added the 🌟 feature New functionality and improvements label May 27, 2020
@pocmo
Copy link
Contributor

pocmo commented May 27, 2020

I am not sure what the state of using flash inside WebView is. I'd bet (or hope) that even in WebView flash content no longer gets loaded/executed - does it work in WebView?

In theory you can build Reference Browser with WebView instead of GeckoView too. It's just not something we do ourselves here, but in Sample Browser in our Android Components repository. If that is something you are interesting in then you could try replacing the geckoview nightly dependency with our browser-engine-system dependency which will use WebView instead:
https://github.com/mozilla-mobile/reference-browser/blob/master/app/build.gradle#L187

There will be some manual changes you will have to do in order to make it still compile after that since we have some code that initializes Gecko here:
https://github.com/mozilla-mobile/reference-browser/blob/master/app/src/main/java/org/mozilla/reference/browser/EngineProvider.kt#L20

Also note that some features, for example WebExtensions, may only work with Gecko and are not functional with WebView.

I'm removing the feature label here since this is not something we will officially support here. But I'll keep the issue open for a while so that you can still ask questions about this.

@pocmo pocmo removed the 🌟 feature New functionality and improvements label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants