(GeckoView) IllegalStateException Display already acquired

[pocmo]

https://sentry.prod.mozaws.net/operations/reference-browser/issues/5168283/

IllegalStateException: Display already acquired
    at org.mozilla.geckoview.GeckoSession.acquireDisplay(GeckoSession.java:1799)
    at org.mozilla.geckoview.GeckoView.setSession(GeckoView.java:342)
    at org.mozilla.geckoview.GeckoView.setSession(GeckoView.java:305)
    at mozilla.components.browser.engine.gecko.GeckoEngineView.render(GeckoEngineView.kt:51)
    at mozilla.components.feature.session.EngineViewPresenter.renderSession$feature_session_release(EngineViewPresenter.kt:50)
...
(35 additional frame(s) were not displayed)

RuntimeException: Failed to call observer method
    at androidx.lifecycle.ClassesInfoCache$MethodReference.invokeCallback(ClassesInfoCache.java:225)
    at androidx.lifecycle.ClassesInfoCache$CallbackInfo.invokeMethodsForEvent(ClassesInfoCache.java:193)
    at androidx.lifecycle.ClassesInfoCache$CallbackInfo.invokeCallbacks(ClassesInfoCache.java:184)
    at androidx.lifecycle.ReflectiveGenericLifecycleObserver.onStateChanged(ReflectiveGenericLifecycleObserver.java:36)
    at androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent(LifecycleRegistry.java:355)
...
(27 additional frame(s) were not displayed)

Failed to call observer method

[pocmo]

org.mozilla.geckoview.GeckoSession in acquireDisplay at line 1799
org.mozilla.geckoview.GeckoView in setSession at line 342
org.mozilla.geckoview.GeckoView in setSession at line 305
mozilla.components.browser.engine.gecko.GeckoEngineView in render at line 51
mozilla.components.feature.session.EngineViewPresenter in renderSession$feature_session_release at line 50
mozilla.components.feature.session.EngineViewPresenter in start at line 30
mozilla.components.feature.session.SessionFeature in start at line 26

[jonalmeida]

I filed an issue for this in Fenix since I came across this crash organically.

[pocmo]

@jonalmeida And do you have steps to reproduce this? This week is the first time this showed up both in our browser and fenix.

[jonalmeida]

@pocmo YES! I just figured it out!

STR:

1. Open a link in a custom tab.
2. Share the link from the custom tab to the same R-B.
3. Observe the crash.

[jonalmeida]

I haven't landed CT in Fenix, only feature-intent, so I'm guessing that might be related in some way.

[pocmo]

Perfect. Thank you!

[boek]

I was able to fix an instance of this in mozilla-mobile/fenix#374

[pocmo]

The cause of the crash is that we are trying to display the same GeckoSession on two GeckoView instances. :)

In the case of the Reference Browser (and STR above) this is a bug in our presenter and we try to display the selected session in the custom tab too. This will be fixed with this PR in AC:
mozilla-mobile/android-components#1967

In Fenix it looks like the Fragment instances is retained (because of the backstack) but the views are destroyed. Since the Fragment keeps a reference to the feature (and the original views) we essentially:

• Leak the original views and keep them in memory
• Render the session on the old and new views (since both are still subscribed)

This issue is something we do not see in our app since we never retain a Fragment and therefore for us "fragment lifetime" == "view lifetime". What we need is to bind a feature to the lifetime of the view and not to the lifecycle owner. I am working on a solution in:
mozilla-mobile/android-components#1943