EngineView doesn't render content below the toolbar

[jonalmeida]

This PR added dynamic adjustment for the engineView, but it wasn't in the right place for when the toolbar scrolls away. This ends up showing blank white boxes where the engine view is when the toolbar is scrolled away.

We need to add that call into the EngineViewBehaviour probably so that we can have it invoked when the toolbar scrolls away.

I did a quick test of the solution I proposed but that doesn't seem like the best way forward.

Note: consider if this has a perf loss to it.

cc: @hiikezoe for reference

[jonalmeida]

Revert the previous addition of the new API that is invoked statically: #977

Add the API to be invoked when the toolbar is dynamically changing height instead in the CoordinatorLayout.Behaviour: mozilla-mobile/android-components#5404

[hiikezoe]

The #977 looks totally wrong to me. The max height shouldn't be changed during the dynamic toolbar transitions.

I suppose the issue here is that the content in question is not scrollable, but the toolbar is able to be hidden? I'd say, in such cases, we should stop the dynamic toolbar transition.

[jonalmeida]

I suppose the issue here is that the content in question is not scrollable, but the toolbar is able to be hidden? I'd say, in such cases, we should stop the dynamic toolbar transition.

Yes, I think you're right that the toolbar shouldn't be hidden which is something we might know from bug 1557411.

I was playing around with this last evening and AC#134 (which I think is what you're referring to) looked much better than a white box on some sites, so I put up that PR but I don't feel strongly about it.