Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #5403: Add setDynamicToolbarMaxHeight to EngineViewBottomBehavior #5404

Closed
wants to merge 1 commit into from

Conversation

jonalmeida
Copy link
Contributor


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #5404 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5404      +/-   ##
============================================
- Coverage     80.34%   80.34%   -0.01%     
+ Complexity     4225     4223       -2     
============================================
  Files           547      546       -1     
  Lines         19230    19198      -32     
  Branches       2778     2775       -3     
============================================
- Hits          15451    15425      -26     
+ Misses         2618     2614       -4     
+ Partials       1161     1159       -2
Impacted Files Coverage Δ Complexity Δ
...ature/session/behavior/EngineViewBottomBehavior.kt 87.5% <0%> (ø) 4 <0> (ø) ⬇️
...ozilla/components/feature/search/SearchUseCases.kt
...components/support/migration/FennecFxaMigration.kt 96.73% <0%> (+0.18%) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9211437...2ec943e. Read the comment docs.

@jonalmeida
Copy link
Contributor Author

@hiikezoe had concerns that this was not the right way to solve the toolbar bug. We should probably be telling the toolbar when it shouldn't scroll away when web content is fixed.

See mozilla-mobile/reference-browser#975 (comment) for the discussion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant