Remove deprecated requestPermissions and onRequestPermissionsResult. #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would also appreciate some manual testing :D |
|
This might not be the most elegant way to do it, but it feels like it's the cleaner one, not including a new API for AC. |
I can do this, but it might affect the DAU numbers if I switch to a different browser. 😄 |
jonalmeida
approved these changes
May 3, 2024
There was a problem hiding this comment.
This looks fine and seems to work in my very limited testing. I can't think of any better way of structuring this today.
I would suggest not landing a similar patch in Fenix/Focus in order to avoid it from bitrotting there and more instances following this pattern until we're sure this is the best way to do it.
| @@ -106,11 +103,13 @@ abstract class BaseBrowserFragment : Fragment(), UserInteractionHandler, Activit | |||
|
|
|||
| protected var webAppToolbarShouldBeVisible = true | |||
|
|
|||
| private lateinit var requestPermissionLauncher: ActivityResultLauncher<Array<String>> | |||
| private lateinit var requestDownloadPermissionsLauncher: ActivityResultLauncher<Array<String>> | |||
| private lateinit var requestsitePermissionsLauncher: ActivityResultLauncher<Array<String>> | |||
There was a problem hiding this comment.
nit: typo
Suggested change
| private lateinit var requestsitePermissionsLauncher: ActivityResultLauncher<Array<String>> | |
| private lateinit var requestSitePermissionsLauncher: ActivityResultLauncher<Array<String>> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist