Add Dependency Analysis Gradle Plugin

[rvandermeulen]

This patch:

• Adds the Dependency Analysis Gradle Plugin to our Gradle setup
• Creates a new linter job in Taskcluster that will fail on any new issues, ensuring we stay up to date down the road
• Cleans up the existing issues found (initial report shown below).

Sample output:

Advice for :app
Unused dependencies which should be removed:
  androidTestImplementation libs.espresso.contrib
  androidTestImplementation libs.espresso.web
  androidTestImplementation libs.junit.ktx
  implementation libs.androidx.activity.compose
  implementation libs.mozilla.concept.tabstray
  implementation libs.mozilla.support.images
  implementation libs.mozilla.ui.autocomplete
  implementation libs.thirdparty.sentry

These transitive dependencies should be declared directly:
  androidTestImplementation 'androidx.test:monitor:1.6.1'
  androidTestImplementation 'com.squareup.okhttp3:okhttp:4.12.0'
  androidTestImplementation 'com.squareup.okio:okio:3.4.0'
  androidTestImplementation 'junit:junit:4.13.2'
  androidTestImplementation 'org.hamcrest:hamcrest:2.2'
  implementation 'androidx.activity:activity:1.7.2'
  implementation 'androidx.annotation:annotation:1.7.1'
  implementation 'androidx.browser:browser:1.8.0'
  implementation 'androidx.cardview:cardview:1.0.0'
  implementation 'androidx.compose.runtime:runtime:1.6.6'
  implementation 'androidx.compose.ui:ui-graphics:1.6.6'
  implementation 'androidx.compose.ui:ui-text:1.6.6'
  implementation 'androidx.coordinatorlayout:coordinatorlayout:1.2.0'
  implementation 'androidx.fragment:fragment:1.6.2'
  implementation 'androidx.lifecycle:lifecycle-common:2.7.0'
  implementation 'androidx.lifecycle:lifecycle-viewmodel:2.7.0'
  implementation 'androidx.recyclerview:recyclerview:1.3.2'
  implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.0'
  implementation 'org.mozilla.appservices.nightly:fxaclient:127.20240427050414'
  implementation 'org.mozilla.components:browser-errorpages:127.0.20240427215438'
  implementation 'org.mozilla.components:concept-base:127.0.20240427215438'
  implementation 'org.mozilla.components:concept-fetch:127.0.20240427215438'
  implementation 'org.mozilla.components:lib-state:127.0.20240427215438'
  implementation 'org.mozilla.components:support-base:127.0.20240427215438'
  implementation 'org.mozilla.geckoview:geckoview-nightly-omni:127.0.20240427215438'

Existing dependencies which should be modified to be as indicated:
  implementation 'org.jetbrains.kotlin:kotlin-stdlib:1.9.23' (was api)

Dependencies which should be removed or changed to runtime-only:
  runtimeOnly libs.kotlinx.coroutines.android (was implementation)

Obviously I would like to extend this to other projects eventually, probably A-S and Glean next since they should be pretty easy. For mozilla-central, it'll probably go hand in hand with an eventual migration to a version catalog as we might as well get all the churn out of the way in one shot.

To run it locally, you just need to use ./gradlew buildHealth.

[mcarare]

great job!

[rvandermeulen]

I'm still trying to come up with a more elegant solution for ignoring the appservices & geckoview warnings. It's not super important for r-b since they're never going to change form from the two being explicitly listed right now, but it's going to be more annoying for central where the exact names will vary depending on channel/variant.

I've got an active thread going upstream about it now. Not necessarily a blocker to land this, but it would be nice to sort out.

[jonalmeida]

I had shared my feedback directly with ryanvm which is already addressed.

Removing myself for now in case you want to request a re-review based on the comment above.

[rvandermeulen]

I haven't heard more from upstream yet. I'm just going to roll with this for now. If I get a more elegant solution, I'll take care of it in a follow-up PR.