Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1267305 fixups #17

Merged

Conversation

nthomas-mozilla
Copy link
Contributor

Fixes several issues with #16

  • url prefs should be set to "about:blank" instead of "" to ensure no tab loads
  • LaterRun pref minTime should be minimumHoursSinceInstall; minSessionCount should be minimumSessionCount
  • LocalizablePreferences yields prefs set to (eg) data:text/plain,browser.laterrun.pages.test.url=https://www.mozilla.org/en-US/%APP%/%VERSION%/secondrun/?f=76&v=2. This causes LaterRun to reject the url. Swapping to Preferences avoids this, and lets us type the boolean and int prefs correctly
  • LaterRun doesn't interpolate any variables like %VERSION% (bug 1270707) so we have to hardcode values in browser.laterrun.pages.test.url. Good thing we've only got one locale here

@nthomas-mozilla nthomas-mozilla merged commit 66c6a0e into mozilla-partners:master May 6, 2016
@nthomas-mozilla nthomas-mozilla deleted the Bug1267305 branch May 9, 2016 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant