Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1212873 - Compute the 95% confidence interval for mean #27

Merged

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Oct 8, 2015


statistics[contextKey].push({
Metric: key,
Mean: mean,
Median: stats.median(values),
Min: Math.min.apply(Math, values),
'95th Perc.': stats.percentile(values, 0.95) || mean,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about making this just 95%?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that be easily confused with the 95% confidence interval? How about we just remove this altogether?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tough thing is the current dependency with how things are done right now, with the way things should actually be. For example, right now all of our metrics in the dashboards display p95. All of our baselines for v2.2 are calculated using p95. All our regression detection scripts query for p95.

All that is to say: we could easily switch everything over to use mean, but we would have to change the messaging around our releases to say that we are abandoning p95 for another alternative. Thoughts?

FYI, here is all the stats for v2.2 I gathered. https://gist.github.com/eliperelman/5aac3b94e2f815dbb827

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, remove p95, use 95% Bound instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this, remove p95, then publish as Raptor v3.0.

eliperelman added a commit that referenced this pull request Oct 8, 2015
Bug 1212873 - Compute the 95% confidence interval for mean
@eliperelman eliperelman merged commit a1c1d6e into mozilla-raptor:master Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants