Attempt to support new manifest format and fetch-bmo.py #8
Conversation
We probably have to update https://github.com/mozilla-releng/adhoc-signing/blob/master/taskcluster/adhoc_taskgraph/signing_manifest.py#L38-L52 . If you can also add |
taskcluster/run-task/fetch-bmo.py
Outdated
| @@ -0,0 +1,253 @@ | |||
| #!/usr/bin/python3 -u | |||
There was a problem hiding this comment.
This file should either live in taskcluster/docker/fetch or taskcluster/script/fetch.
taskcluster/docker/fetch/Dockerfile
Outdated
| @@ -24,6 +24,9 @@ RUN apt-get update && \ | |||
|
|
|||
| # %include-run-task | |||
|
|
|||
| # %include taskcluster/run-task/fetch-bmo.py | |||
| ADD topsrcdir/taskcluster/run-task/fetch-bmo.py /builds/worker/bin/fetch-bmo.py | |||
There was a problem hiding this comment.
I would be inclined to use /usr/local/bin/fetch-bmo.
| cmd = [ | ||
| 'bash', | ||
| '-c', | ||
| 'cd {} && ' |
There was a problem hiding this comment.
Instead of setting the current directory, you should pass the full path to the destination here.
| 'bash', | ||
| '-c', | ||
| 'cd {} && ' | ||
| '/usr/bin/python3 {} {}'.format( |
There was a problem hiding this comment.
I would be inclined to defer to the shebang, rather than explicitly calling python. This will require chmod +x in the dockerfile.
Callek
force-pushed
the
fetch-bmo
branch
2 times, most recently
from
1778f4b
to
72f1eda
Compare
| fetch['type'] = manifest["fetch"].get('type', 'static-url') | ||
| if fetch['type'] == 'static-url': | ||
| fetch["url"] = manifest["fetch"]["url"] | ||
| if manifest.get('gpg-signature'): |
There was a problem hiding this comment.
Should we put gpg-signature into the fetch block directly, rather than look for it elsewhere in the manifest and put it in the fetch block?
Callek
force-pushed
the
fetch-bmo
branch
2 times, most recently
from
f5af14e
to
9160e56
Compare
No description provided.