bug 1282841: can't set background rate to 0 for new rules (#189). r=b…

…hearsum

auslib/admin/views/forms.py

@@ -8,6 +8,7 @@
 from auslib.util.timestamp import getMillisecondTimestamp
 from auslib.util.versions import MozillaVersion
 
+
 import logging
 log = logging.getLogger(__name__)
 
@@ -168,7 +169,7 @@ class PartialReleaseForm(Form):
 
 
 class RuleForm(Form):
-    backgroundRate = IntegerField('Background Rate', validators=[Required(), NumberRange(0, 100)])
+    backgroundRate = IntegerField('Background Rate', validators=[NumberRange(0, 100, "Background rate must be between 0 and 100")])
     priority = IntegerField('Priority', validators=[Required()])
     mapping = SelectField('Mapping', validators=[])
     fallbackMapping = NullableStringField('fallbackMapping', validators=[Optional()])

auslib/test/admin/views/test_rules.py

@@ -36,6 +36,17 @@ def testNewRulePost(self):
         self.assertEquals(r[0]['priority'], 33)
         self.assertEquals(r[0]['data_version'], 1)
 
+    def testBackgroundRateZero(self):
+        ret = self._post('/rules', data=dict(backgroundRate=0, mapping='c', priority=33,
+                                             product='Firefox', update_type='minor', channel='nightly'))
+        self.assertEquals(ret.status_code, 200, "Status Code: %d, Data: %s" % (ret.status_code, ret.data))
+        r = dbo.rules.t.select().where(dbo.rules.rule_id == ret.data).execute().fetchall()
+        self.assertEquals(len(r), 1)
+        self.assertEquals(r[0]['mapping'], 'c')
+        self.assertEquals(r[0]['backgroundRate'], 0)
+        self.assertEquals(r[0]['priority'], 33)
+        self.assertEquals(r[0]['data_version'], 1)
+
     def testNewRulePostJSON(self):
         data = dict(
             backgroundRate=31, mapping="c", priority=33, product="Firefox",