Skip to content

Commit

Permalink
bug 1461405: no option to sign off on release blob changes via fronte…
Browse files Browse the repository at this point in the history
…nd (#584). r=jlorenzo
  • Loading branch information
bhearsum committed May 15, 2018
1 parent 1c50664 commit b90c50a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions ui/app/templates/release_scheduled_changes.html
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ <h2>
<h3 class="panel-title">
<div style="float: right">
<i ng-if="scheduled_changes_count && $first && (currentPage == 1)">Current</i>
<button ng-show="!sc.sc_id && (! isEmpty(sc['required_signoffs']) &&
<button ng-show="!sc_id && (! isEmpty(sc['required_signoffs']) &&
!sc['signoffs'].hasOwnProperty(current_user))" class="btn btn-xs btn-primary" ng-click="signoff(sc)">
Signoff as...
</button>
<button ng-show="!sc.sc_id && (! isEmpty(sc['required_signoffs']) &&
<button ng-show="!sc_id && (! isEmpty(sc['required_signoffs']) &&
sc['signoffs'].hasOwnProperty(current_user))" class="btn btn-xs btn-danger" ng-click="revokeSignoff(sc)">
Revoke your Signoff
</button>
Expand All @@ -69,7 +69,7 @@ <h3 class="panel-title">
</h3>
</div>
<div class="panel-body">
<div ng-show="!sc.sc_id && ! isEmpty(sc.required_signoffs)">
<div ng-show="!sc_id && ! isEmpty(sc.required_signoffs)">
<span style="float: left">
<h4>Before it can be enacted, this change must be signed off on by:</h4>
<ul>
Expand Down
4 changes: 2 additions & 2 deletions ui/app/templates/rule_scheduled_changes.html
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ <h2>
<h3 class="panel-title">
<div style="float: right">
<i ng-if="scheduled_changes_rules_count && $first && (currentPage == 1)">Current</i>
<button ng-show="sc.sc_id && (!isEmpty(sc['required_signoffs']) &&
<button ng-show="sc_id && (!isEmpty(sc['required_signoffs']) &&
!sc['signoffs'].hasOwnProperty(current_user))" class="btn btn-xs btn-primary" ng-click="signoff(sc)">
Signoff as...
</button>
<button ng-show="sc.sc_id && (!isEmpty(sc['signoffs']) &&
<button ng-show="sc_id && (!isEmpty(sc['signoffs']) &&
sc['signoffs'].hasOwnProperty(current_user))" class="btn btn-xs btn-danger" ng-click="revokeSignoff(sc)">
Revoke your Signoff
</button>
Expand Down

0 comments on commit b90c50a

Please sign in to comment.