Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't allow rules to map to have a mapping to a release with a non-matching product #1061

Open
bhearsum opened this issue Dec 20, 2019 · 0 comments
Labels
admin admin app & api (aus4-admin.mozilla.org) db database layer

Comments

@bhearsum
Copy link
Contributor

While thinking about bug 1309656, I realized that it's currently possible to do something very silly and point a Firefox update rule at a non-Firefox Release. Even in a multifile update world I can't see a scenario where this would be desired, and there may be some potential for privilege escalation or creating confusion (eg: create a release with product=Thunderbird, name=Firefox-$version-we're-about-to-ship) that might lead to the wrong thing being served.

This probably needs a bit more thought about whether or not its a good idea.

(Imported from https://bugzilla.mozilla.org/show_bug.cgi?id=1309877)

@bhearsum bhearsum added admin admin app & api (aus4-admin.mozilla.org) db database layer labels Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin admin app & api (aus4-admin.mozilla.org) db database layer
Projects
None yet
Development

No branches or pull requests

1 participant