Look through platform alias' from current release when evaluating pre… #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1667667 |
bhearsum
force-pushed
the
match-partials-with-alias
branch
from
c43461d
to
e65a785
Compare
…vious releases for a partial update eligibility Ideally, we'd fix the client submit alias' for dated blobs, but that's a much trickier fix, and probably not a worthwhile one given that after we complete nightly shippable/release convergence work, that code will just go away. In theory, this fix could cause us to attempt to serve a partial that's not valid for a request. This can only happen if we change the meaning a build target at some point (so that the alias' from the current blob don't match expectations of the earlier versions). This has never happened in my time here -- we always add a new build target instead. If this does happen at some point, the failure mode would be the partial failing to apply...so I think it's an OK risk to take here.
bhearsum
force-pushed
the
match-partials-with-alias
branch
from
e65a785
to
5a9fdbe
Compare
escapewindow
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vious releases for a partial update eligibility
Ideally, we'd fix the client submit alias' for dated blobs, but that's a
much trickier fix, and probably not a worthwhile one given that after we
complete nightly shippable/release convergence work, that code will just
go away.
In theory, this fix could cause us to attempt to serve a partial that's
not valid for a request. This can only happen if we change the meaning a
build target at some point (so that the alias' from the current blob
don't match expectations of the earlier versions). This has never
happened in my time here -- we always add a new build target instead. If
this does happen at some point, the failure mode would be the partial
failing to apply...so I think it's an OK risk to take here.