Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require two releng signoffs for changes to permissions #2528

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabrielBusta
Copy link
Member

@gabrielBusta
Copy link
Member Author

gabrielBusta commented May 16, 2022

I tried to implement two admin sign-offs. Because that moves us from looking at "roles" when checking sign-offs to looking at "permissions" it required refactoring in the back-end and UI. I ended up hard-coding 2 "releng" sign-offs. Before this lands in production we need to make sure that nobody currently has that role that shouldn't.

Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit unhappy about hardcoding a specific role here (iirc we don't do that anywhere else). More importantly, this will break local setups where there may not be 2 users with that role.

Finally, before we merge anything we'll need to add tests.

@gabrielBusta gabrielBusta force-pushed the two-releng-signoffs-for-permissions-changes branch 2 times, most recently from 79b5c57 to 74b954c Compare May 20, 2022 18:15
@gabrielBusta gabrielBusta force-pushed the two-releng-signoffs-for-permissions-changes branch from 74b954c to 717fbe6 Compare June 16, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants