Configure webpack production build to avoid using devtools that rely on eval #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielBusta
commented
Mar 20, 2024
gabrielBusta
commented
Mar 20, 2024
| alias: { | ||
| 'react-native': 'react-native-web', | ||
| 'react-dom': '@hot-loader/react-dom', | ||
| module.exports = env => { |
There was a problem hiding this comment.
There's a lot of noise around here because the indentation changed.
bhearsum
reviewed
Mar 20, 2024
gabrielBusta
commented
Mar 20, 2024
gabrielBusta
commented
Mar 20, 2024
| [ | ||
| '@babel/preset-react', | ||
| { | ||
| development: env === 'development', |
There was a problem hiding this comment.
Don't set development to true in production builds.
gabrielBusta
commented
Mar 20, 2024
| }, | ||
| plugins: [ | ||
| '@babel/plugin-syntax-dynamic-import', | ||
| ...(env === 'development' ? ['react-hot-loader/babel'] : []), |
There was a problem hiding this comment.
Don't use react-hot-loader/babel in production builds.
Oh - nevermind. Hiding whitespace gets rid of most of it. |
|
Yes. The reason for this is that we are now reading the env and configuring the build based on that. Because the export is now a function instead of a plain object the indentation changed and it looks like more changes than it is. |
bhearsum
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Neutrino was doing this for us.
This should take care of the eval calls in the transpiled production code.