Kill version in releases table. #51
Conversation
| row, = table.history.select( | ||
| where=[table.history.version == '222.0'], | ||
| where=[table.history.product == 'd'], | ||
| limit=1 | ||
| ) |
There was a problem hiding this comment.
I think we ought to add some sort of reverse sorting here, to ensure we revert the most-recent change.
|
r+, but please make testPostRevisionRollback a little more robust prior to merging. And just to confirm - a submission script that still sends a version will be fine, that'll be ignored ? |
|
I'll definitely fix up that test first. That's a very good point about the submission script though...I think it may cause a 400. I'll look into that as well. |
|
Looks like passing random unknown POST arguments doesn't break anything, so we're good on that front: http://people.mozilla.org/~bhearsum/sattap/2a89a05f.png. I'll be updating the submission script anyways though, of course. I'll push a fix for testPostRevisionRollback in a bit. |
|
How's this @nthomas-mozilla? |
|
Looks good to me. |
bug 741412: Kill version in releases table. r=nthomas
I also improved the UI in a couple of places: