Skip to content
This repository has been archived by the owner on Dec 31, 2019. It is now read-only.

Production push doc update #158

Merged
merged 3 commits into from
Jun 26, 2018
Merged

Conversation

nthomas-mozilla
Copy link
Contributor

  • process changes for puppet move to github
  • move of puppet repo into mozilla-releng org
  • add note to wait for masters to sync requirements.txt change

@tomprince
Copy link
Contributor

This should have a newsfragement.

Copy link
Contributor

@MihaiTabara MihaiTabara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to what @tomprince said. However I'm not sure what should we prefix the files with in the absence of bug numbers.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 556

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.913%

Totals Coverage Status
Change from base Build 554: 0.0%
Covered Lines: 455
Relevant Lines: 460

💛 - Coveralls

@MihaiTabara
Copy link
Contributor

Come to think about it after chatting with @nthomas-mozilla - this raises the question, some of the PRs are not quliafiying for a bug number, hence am not sure they should really have a newsfragment. I mean, any code change that can affect functionality should have a bug number I suppose, but for doc fixing or tooling (e.g. tox, coveralls, etc) I don't think it's worth filing a bug.

@tomprince what do you think?

@MihaiTabara
Copy link
Contributor

Let's make a consensus: any changes that don't have a tracking bug number in Bugzilla can ignore the newsfragment I suppose. In this category we can definitely shove the update of the info files (README, requirements, etc). We can always come back and change this.

@MihaiTabara
Copy link
Contributor

Pushing this to be grabbed in the upcoming 7.5.0 roll-out

@MihaiTabara MihaiTabara merged commit f4b1e13 into mozilla-releng:master Jun 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants