Skip to content
This repository has been archived by the owner on Dec 31, 2019. It is now read-only.

Support win64-asan-reporter and mac-asan-reporter platforms #170

Merged
merged 2 commits into from Jul 20, 2018

Conversation

choller
Copy link
Contributor

@choller choller commented Jul 11, 2018

These changes are similar to what catlee did before for Linux to support asan-reporter.

I am currently working on Windows support in bug 1473259 but Mac support is also planned and I figured it is easier to make these changes in one on the beetmover side, so it is less work to deploy.

I am also going to change the m-c patch in that bug to match the platform descriptor used here (win64-asan-reporter).

@coveralls
Copy link

coveralls commented Jul 11, 2018

Pull Request Test Coverage Report for Build 614

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.763%

Totals Coverage Status
Change from base Build 613: 0.0%
Covered Lines: 479
Relevant Lines: 485

💛 - Coveralls

Copy link
Contributor

@MihaiTabara MihaiTabara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@choller want me to roll-it out to production ASAP?

@choller
Copy link
Contributor Author

choller commented Jul 12, 2018

@MihaiTabara I would very much appreciate that! Please let me know as soon as it is in production, so I can kick off a new try run with the mozilla-central patch.

@MihaiTabara
Copy link
Contributor

@choller

  • hope you don't mind, I pushed a tiny commit to fix the CHANGELOG vs newsfragment to keep things consistent with previous PRs
  • I pushed your changes to all our dev beetmoverworkers (which are used on try branch)
  • I couldn't rerun the beetmover-repackage job since it's way passed its deadline, but feel free to push again to try to see if things go smoothly. If it breaks again, I can follow-up with fixes and reruns to see it done today.

Copy link
Contributor

@MihaiTabara MihaiTabara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to go live. Merging to master

@MihaiTabara MihaiTabara merged commit 6e1a66b into mozilla-releng:master Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants