Bug 1423885 - Yet another milestone beetmoverscript

[MihaiTabara]

• fixes checksums
• fixes devedition
• misc

[coveralls]

Coverage remained the same at 100.0% when pulling 6071683 on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 180df4b on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 180df4b on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 63ee66f on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 0cebfcc on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 0cebfcc on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling f029210 on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 6de8b82 on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 6de8b82 on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling b55be10 on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling ea59270 on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling a591401 on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 5f38f61 on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[escapewindow]

Looks good! CHANGELOG.md could have more explicit changes listed, and we may want to follow semver and bump to 4.0.0.

[escapewindow]

We seem to also have added .beet support in general, no?
Also, get_product_name, NORMALIZED_BALROG_PLATFORMS.

[MihaiTabara]

Makes sense, I must have missed some of these in the previous milestone. Will follow-up with a push.

[escapewindow]

This is a breaking change. It's not as critical for beetmoverscript to respect semver since we have nothing downstream. But if we follow semver, we would bump the major version. 4.0.0.

[MihaiTabara]

Thanks for making this comment. To be honest I was walking on the fence yesterday between MAJOR and MINOR bump https://semver.org/ and wasn't sure since these functions aren't used anywhere downstream. But at a second look, you're right. With my logic at hand, we would never bump the MAJOR :)

[escapewindow]

As mentioned in person, we can use graph generation to take attributes['shipping_product'] and turn it into a task.payload.product; similarly we could use build_platform and turn it into a task.payload.platform. If we accept those as optional task payload schema items, and keyed off of them if they exist, then we could slowly reduce the need for balrog_props.json.

[MihaiTabara]

Yep, this makes totally sense. This is in my tcmigration cleaup list for beetmover as my reasoning was to first roll-out the milestone version and then follow-up with a potential MINOR bump. I'd like to add proper testing when I make a sensitive change like that and I didn't want to hold back the landing from maple => central this week. I can include those changes as well if you want me to though.

[coveralls]

Coverage remained the same at 100.0% when pulling 38fec94 on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling ded1c13 on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling ded1c13 on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.

[coveralls]

Coverage remained the same at 100.0% when pulling dd33036 on MihaiTabara:sums into dc2f8cd on mozilla-releng:master.