Skip to content
This repository has been archived by the owner on Jun 11, 2019. It is now read-only.

Commit

Permalink
Bug 1289514 - Remove empty dataFailed method; r=catlee
Browse files Browse the repository at this point in the history
The method was previously crippled. It was dispatching to its parent
class, making the method essentially worthless. The only value was
the commented code. And since that code dealt with recovering from
reset repos, which the previous commit and subsequent commits will
address, there is no value to the commented code so it can be
deleted.

MozReview-Commit-ID: 3QQMRR8A4oq

--HG--
extra : rebase_source : 80124338eac9b86e4526a75d6c4395297707bbb3
extra : amend_source : d63c6945df392a5525d090028225ca81df1310d8
extra : histedit_source : 2e73a62bc15a9761cc0b79f2417e4e682fa4863e
  • Loading branch information
indygreg committed Jul 26, 2016
1 parent fef3c37 commit a7fe215
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions changes/hgpoller.py
Expand Up @@ -272,19 +272,6 @@ def _make_url(self):

return str(url)

def dataFailed(self, res):
# XXX: disabled for bug 774862
# if hasattr(res.value, 'status') and res.value.status == '500' and \
#'unknown revision' in res.value.response:
## Indicates that the revision can't be found. The repo has most
## likely been reset. Forget about our lastChangeset, and set
## emptyRepo to True so we can trigger builds for new changes there
# if self.verbose:
# log.msg("%s has been reset" % self.baseURL)
# self.lastChangeset = None
# self.emptyRepo = True
return self.super_class.dataFailed(self, res)

def processData(self, query):
push_data = parse_pushlog_json(query)

Expand Down

0 comments on commit a7fe215

Please sign in to comment.