Support file objects in MarFile #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Python 3 doesn't like my "basestring"... |
| self.fileobj = open(name, 'rb') | ||
| else: | ||
| # Assuming that a file object passed | ||
| self.name = name.name |
There was a problem hiding this comment.
not all file objects have names, StringIO objects in particular!
catlee
added a commit
that referenced
this pull request
Jul 27, 2017
* [requires.io] dependency update on master branch (#7) * [requires.io] dependency update * [requires.io] dependency update * [requires.io] dependency update on master branch (#8) * [requires.io] dependency update * [requires.io] dependency update * [requires.io] dependency update * [requires.io] dependency update * [requires.io] dependency update * [requires.io] dependency update * [requires.io] dependency update * [requires.io] dependency update * [requires.io] dependency update on master branch (#9) * [requires.io] dependency update * Add support for XZ compressed mar files * Fix verification to fail if a signature block exists with no signatures * Add usage examples * Use same LZMA compressor options as C version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought about adding a classmethod (from_fileboj()), but that would require changint the init() signature and break consumers.