Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get up to 100% coverage #4

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Get up to 100% coverage #4

merged 1 commit into from
Oct 31, 2018

Conversation

JohanLorenzo
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+75.8%) to 100.0%
Totals Coverage Status
Change from base Build 5: 75.8%
Covered Lines: 86
Relevant Lines: 86
💛 - Coveralls

MihaiTabara
MihaiTabara approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@MihaiTabara MihaiTabara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this is ready to be ported under `mozilla-releng account.

@JohanLorenzo JohanLorenzo merged commit c09861a into master Oct 31, 2018
@JohanLorenzo JohanLorenzo deleted the full-coverage branch October 31, 2018 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MihaiTabara MihaiTabara MihaiTabara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohanLorenzo @coveralls @MihaiTabara