Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop future dependency by using "raise ... from" #102

Closed
whimboo opened this issue Apr 11, 2023 · 4 comments · Fixed by #103
Closed

Drop future dependency by using "raise ... from" #102

whimboo opened this issue Apr 11, 2023 · 4 comments · Fixed by #103

Comments

@whimboo
Copy link
Contributor

whimboo commented Apr 11, 2023

I can see that the mozilla-version package depends on the future package only because of the raise_from usage.

Both instances of the usage actually say:

TODO Use "raise from" statement once Python 2 support is dropped

Given that Python 2 is no longer a thing it would be good to drop the future package from the dependencies because it is quite large in size.

@whimboo
Copy link
Contributor Author

whimboo commented Apr 11, 2023

@JohanLorenzo I would appreciate if this could be fixed. We need to use this package now in mozdownload and I would like to not see a 2MB package needed to be installed. Thanks a lot.

jcristau added a commit to jcristau/mozilla-version that referenced this issue Apr 11, 2023
jcristau added a commit to jcristau/mozilla-version that referenced this issue Apr 11, 2023
jcristau added a commit to jcristau/mozilla-version that referenced this issue Apr 11, 2023
jcristau added a commit to jcristau/mozilla-version that referenced this issue Apr 11, 2023
@jcristau jcristau linked a pull request Apr 11, 2023 that will close this issue
@whimboo
Copy link
Contributor Author

whimboo commented Apr 12, 2023

Thanks for this quick PR! @JohanLorenzo would you have an ETA when the new version could be released?

@JohanLorenzo
Copy link
Contributor

I assume it's going to be soon enough thanks to #104 but I defer to @jcristau.

@jcristau
Copy link
Collaborator

This is part of https://pypi.org/project/mozilla-version/2.0.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants