Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Travis-CI build a local copy of docs #12

Merged
merged 7 commits into from
Aug 20, 2018

Conversation

JohanLorenzo
Copy link
Contributor

@JohanLorenzo JohanLorenzo commented Aug 20, 2018

In #10, I wanted to be sure m2r didn't break readthedocs. This PR adds a tox job that ensures docs can be written. I also revisited the deps to use hashes like in the scriptworker world

@coveralls
Copy link

coveralls commented Aug 20, 2018

Pull Request Test Coverage Report for Build 86

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 79: 0.0%
Covered Lines: 244
Relevant Lines: 244

💛 - Coveralls

@JohanLorenzo JohanLorenzo mentioned this pull request Aug 20, 2018
Copy link
Contributor

@MihaiTabara MihaiTabara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beautiful. Thanks for adding the suplimentary check(s)!


commands=
pip install -e . --no-deps # see note on skip_install above
pip check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohanLorenzo JohanLorenzo merged commit ecc1ff1 into mozilla-releng:master Aug 20, 2018
@JohanLorenzo JohanLorenzo deleted the fail-on-bad-docs branch July 26, 2019 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants