-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let Travis-CI build a local copy of docs #12
Merged
JohanLorenzo
merged 7 commits into
mozilla-releng:master
from
JohanLorenzo:fail-on-bad-docs
Aug 20, 2018
Merged
Let Travis-CI build a local copy of docs #12
JohanLorenzo
merged 7 commits into
mozilla-releng:master
from
JohanLorenzo:fail-on-bad-docs
Aug 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanLorenzo
force-pushed
the
fail-on-bad-docs
branch
from
August 20, 2018 09:53
ff1a082
to
42815ce
Compare
JohanLorenzo
force-pushed
the
fail-on-bad-docs
branch
from
August 20, 2018 12:21
7f2b1bd
to
9cc9f18
Compare
Merged
JohanLorenzo
force-pushed
the
fail-on-bad-docs
branch
from
August 20, 2018 13:05
018074d
to
af14856
Compare
MihaiTabara
approved these changes
Aug 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is beautiful. Thanks for adding the suplimentary check(s)!
|
||
commands= | ||
pip install -e . --no-deps # see note on skip_install above | ||
pip check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10, I wanted to be sure m2r didn't break readthedocs. This PR adds a tox job that ensures docs can be written. I also revisited the deps to use hashes like in the scriptworker world