Fix never running coveralls and make it explicitly fail on Travis #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanLorenzo
changed the title
JohanLorenzo
force-pushed
the
fix-coveralls
branch
from
b4f4736
to
b2950d6
Compare
danlabici
approved these changes
Sep 7, 2018
This was referenced Sep 7, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous PRs, the Coveralls job never returned any results. This is caused by errors like https://travis-ci.org/mozilla-releng/mozilla-version/jobs/425272047#L542. It seems the
python-coverallspackage is running on a too old version ofcoverage. Let's usepython-coveralls(akacoveralls) which is also supported by coveralls.io https://docs.coveralls.io/python. As you can see, results are back!I also made sure we don't silently fail on such errors anymore.