Upgrade pushapkscript to use scriptworker v1.0.0b4 (without chain of trust enabled) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escapewindow
approved these changes
Jan 9, 2017
| self.assertEqual(get_default_config(), { | ||
| 'work_dir': '/a/current/work_dir', | ||
| 'schema_file': '/a/current/dir/pushapkscript/data/pushapk_task_schema.json', | ||
| 'valid_artifact_rules': { |
There was a problem hiding this comment.
I think the test's failing because this needs to be a list of dicts.
JohanLorenzo
force-pushed
the
scriptworker-1.0.0
branch
from
52dfc92
to
52be550
Compare
(without chain of trust enabled)
JohanLorenzo
force-pushed
the
scriptworker-1.0.0
branch
from
52be550
to
fe183bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, the only change needed was related
valid_artifact_rules. I plan to hard code it until Chain of Trust is enabled. Once it is, artifacts will be downloaded directly via scripworker, so pushapkscript won't have to know about this anymore. Because the config file has to be changed, v0.2.0 should be released (at any point) after this patch.This also upgrades mozapkpublisher (enables better logging and uses new versions of store_l10n cc @flodolo ).
This has been tested locally as far as I could get: APKs are refused by Google Play because we don't have more recent APK to provide (except the single locale ones, but that check stops the publishing at an earlier step).