Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves Travis Xenial image using Java11 instead of Java8 #50

Merged
merged 1 commit into from Nov 9, 2018
Merged

Resolves Travis Xenial image using Java11 instead of Java8 #50

merged 1 commit into from Nov 9, 2018

Conversation

mitchhentges
Copy link
Contributor

No description provided.

@mitchhentges mitchhentges changed the title Replaces jdk_switcher usage with jdk matrix key [WIP] Replaces jdk_switcher usage with jdk matrix key Nov 9, 2018
@coveralls
Copy link

coveralls commented Nov 9, 2018 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 2e8cc15 on mitchhentges:fix-travis-jdk-switcher into 91aaa35 on mozilla-releng:master.

@mitchhentges mitchhentges force-pushed the fix-travis-jdk-switcher branch 21 times, most recently from 22cc045 to 52291e8 Compare November 9, 2018 21:50
@mitchhentges mitchhentges changed the title [WIP] Replaces jdk_switcher usage with jdk matrix key Replaces jdk_switcher usage with jdk matrix key Nov 9, 2018
@mitchhentges mitchhentges changed the title Replaces jdk_switcher usage with jdk matrix key Resolves Travis Xenial image using Java11 instead of Java8 Nov 9, 2018
escapewindow
escapewindow approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@escapewindow escapewindow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mitchhentges mitchhentges merged commit 0fa1fec into mozilla-releng:master Nov 9, 2018
@mitchhentges mitchhentges deleted the fix-travis-jdk-switcher branch November 9, 2018 22:28
@mitchhentges mitchhentges mentioned this pull request Nov 9, 2018
Closed
@JohanLorenzo
Copy link
Contributor

Awesome, that's a great finding! Thank you very much for fixing this cleanly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escapewindow escapewindow escapewindow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mitchhentges @coveralls @JohanLorenzo @escapewindow