Explicit channel #24
Merged
Explicit channel #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomprince
force-pushed
the
explicit-channel
branch
from
b0bbcf3
to
63064fd
Compare
The scopes are still used to verify permission when pushing to a real store.
tomprince
force-pushed
the
explicit-channel
branch
from
63064fd
to
175daf7
Compare
JohanLorenzo
approved these changes
Jun 28, 2019
| @pytest.mark.parametrize('channel, push_to_store, expected', ( | ||
| ('beta', True, True), | ||
| ('candidate', True, True), | ||
| ('esr/stable', True, True), |
There was a problem hiding this comment.
Nit: Let's add a case for esr/candidate
| @pytest.mark.parametrize('raises, scopes, channel', ( | ||
| (False, ['project:releng:snapcraft:firefox:candidate'], 'candidate'), | ||
| (False, ['project:releng:snapcraft:firefox:beta'], 'beta'), | ||
| (False, ['project:releng:snapcraft:firefox:esr'], 'esr/stable'), |
There was a problem hiding this comment.
Nit: Let's add a case for esr/candidate
|
|
||
| channel = scope[len(SNAP_SCOPES_PREFIX):] | ||
| def get_snap_channel(config, task): | ||
| if 'channel' in task['payload']: |
There was a problem hiding this comment.
👍 for preserving backwards compatibility \o/
|
Depends on #25 |
Stop importing snapcraft via submodule.
tomprince
force-pushed
the
explicit-channel
branch
3 times, most recently
from
bf846d9
to
31eeabf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.