Use only one log file (live_backing.log) #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanLorenzo
changed the title
escapewindow
approved these changes
Jan 17, 2017
| @@ -79,35 +79,33 @@ def update_logging_config(context, log_name=None, file_name='worker.log'): | |||
| break | |||
|
|
|||
|
|
|||
| def get_log_filenames(context): | |||
| def get_log_filename(context): | |||
There was a problem hiding this comment.
A function to return one constant string might be overkill, but it works :)
JohanLorenzo
added a commit
that referenced
this pull request
Jan 19, 2017
* This requires: 1. the presence of a public/logs/live_backing.log (done in #59) 2. the file to be gzip'd 3. and served as a gzip on S3 * Gzip more type of files and force some extension to text/plain * Create the package scriptworker.artifacts (breaking change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin off that came out of this discussion in #53. I split the changes in a new PR in order to make the review simpler.
PR also tested manually with https://tools.taskcluster.net/task-inspector/#ZXKOTGt1Qq6rUmPFDKfDmw/0