Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cot verification: a decision task shouldn't add its decision task to the chain #77

Closed
escapewindow opened this issue Feb 13, 2017 · 0 comments

Comments

@escapewindow
Copy link
Contributor

In bug 1338933, I retriggered a decision task.

The original decision task had a matching taskId and taskGroupId, because it was created through cron.yml.

The retriggered decision task had mismatched taskId and taskGroupId, because it was retriggered with the taskGroupId from the original decision task.

However, if the retriggered decision task is otherwise well-formed and pointing at a valid tree, we shouldn't need to trace it back to the original decision task.

I'm thinking we should put in an exception to the taskGroupId rule: if a task is a decision task, don't trace it back to its original decision task. This assumes that all decision tasks are traceable back to the tree and mach taskgraph currently. If that changes, then we'll have to revisit this rule.

escapewindow added a commit that referenced this issue Feb 14, 2017
allow for retriggered decision tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant