allow for unsigned cot artifacts when verify_cot_signature is False #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This python-gnupg behavior seems to have changed, or my memory is faulty. I remember `gpg.decrypt` returning an unsigned body when the input was signed, and returning the original string when the input wasn't signed. Now we're dying on `verify_chain_of_trust: True`, `verify_cot_signature: False`, and an unsigned cot artifact. Get around this by explicitly returning the original string if `verify_cot_signature` is `False`, and if `gpg.decrypt` returns an empty string.
|
@MihaiTabara had enough of reviews yet??? ;-D |
|
Sorry about not reviewing this today. I opened it in a tab in the morning and closed accidentally and forgot of it. I really wish Github had a "review queue" or something to warn me for pendings. |
|
No worries! You've reviewed a lot this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This python-gnupg behavior seems to have changed, or my memory is
faulty. I remember
gpg.decryptreturning an unsigned body when theinput was signed, and returning the original string when the input
wasn't signed. Now we're dying on
verify_chain_of_trust: True,verify_cot_signature: False, and an unsigned cot artifact.Get around this by explicitly returning the original string if
verify_cot_signatureisFalse, and ifgpg.decryptreturns an emptystring.