Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.0: Pull gpg homedir creation out of the main scriptworker process. #22

Merged
merged 5 commits into from Nov 1, 2016

Commits on Oct 29, 2016

  1. Pull gpg homedir creation out of the main scriptworker process.

    Originally, gpg homedir creation happened before scriptworker launched,
    and then a background async task polled git and rebuilt the gpg homedirs
    if it found a new valid git commit.  In order to sign the gpg keys in
    the background, we used async pexpect.
    
    However, as noted in mozilla-releng#21, async pexpect isn't reliable currently.  Our
    options included fixing the upstream pexpect bug or pulling the gpg
    homedir creation into a separate process that we can call via cron.
    
    This patch allows us to use that latter approach.
    escapewindow committed Oct 29, 2016
    Copy the full SHA
    c71530d View commit details
    Browse the repository at this point in the history
  2. update changelog

    escapewindow committed Oct 29, 2016
    Copy the full SHA
    b8eda20 View commit details
    Browse the repository at this point in the history
  3. stricter gpg homedir lockfile usage.

    Previously, we were creating the gpg lockfile before recreating the
    worker gpg homedirs, but after recreating ~/.gnupg to verify the git
    repo commits.  This meant we were recreating ~/.gnupg every five
    minutes, and could have resulted in a long-running process overrunning
    the next, especially if we ever shorten the frequency.
    
    Now we create the lockfile before doing any of it, and clean up after
    we're done.  I plan to file a bug about nagios checks for the age of the
    lockfile and the various scriptworker logs, so we catch if any of these
    take significantly longer than expected.
    escapewindow committed Oct 29, 2016
    Copy the full SHA
    58e4b1a View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2016

  1. address review comments

    escapewindow committed Nov 1, 2016
    Copy the full SHA
    f59475a View commit details
    Browse the repository at this point in the history
  2. 0.9.0

    escapewindow committed Nov 1, 2016
    Copy the full SHA
    2f8e623 View commit details
    Browse the repository at this point in the history