get_upstream_artifacts_full_paths_per_task_id(): Add test to ensure s… #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome edge cases are covered
MihaiTabara
approved these changes
Jul 10, 2018
| 'taskId': 'dependency3', | ||
| 'taskType': 'signing', | ||
| }, { | ||
| # Case where the same taskId was given. In some occasion we may want to split |
There was a problem hiding this comment.
Hah, this is neat, wasn't sure this is possible.
| try: | ||
| os.makedirs(os.path.join(folder, os.path.dirname(path))) | ||
| except FileExistsError: | ||
| pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ome edge cases are covered
While working on mozilla-releng/beetmoverscript#163, I had a doubt on whether
get_upstream_artifacts_full_paths_per_task_id()was able to handle payloads like:{ "upstreamArtifacts": [{ "taskId": "one", "paths": ["some_path"] }, { "taskId": "one", "paths": ["some_other_path"] }] }It turns out it can! I updated the test to cover this kind of use case + 2 others.