Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't retry on 404s. #300

Merged
merged 1 commit into from Jan 15, 2019
Merged

Conversation

escapewindow
Copy link
Contributor

@escapewindow escapewindow commented Jan 12, 2019

I noticed that we were retrying 404s for downloading the currently largely nonexistent chain-of-trust.json{,.sig} files in #294... this means it takes us a few minutes to realize that yes, the file is in fact missing. I think not retrying on 404 is ok; if the file is there but we have other issues, it'll be a non-404 status.

If we think this might have larger repercussions, I can retry on BaseDownloadError in most cases, and override that with just DownloadError specifically for downloading chain-of-trust.json{,.sig} until we create those files across all 3 worker implementations.

What do you think, @JohanLorenzo , @tomprince ?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2f72b66 on escapewindow:Download404 into 276f4a0 on mozilla-releng:master.

@escapewindow
Copy link
Contributor Author

(This mainly works because this line doesn't include Download404 in the list of exceptions to retry on).

Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach makes sense to me. On top of my head, I can't think of a case where we want to wait on a 404. That might happen when an artifact isn't present in a given region. However, as this case occurs less often than failing on a missing CoT artifact, I think it's worth giving a try.

@escapewindow
Copy link
Contributor Author

Let's give it a try.

@escapewindow escapewindow merged commit 981e971 into mozilla-releng:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants