Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we were retrying 404s for downloading the currently largely nonexistent
chain-of-trust.json{,.sig}
files in #294... this means it takes us a few minutes to realize that yes, the file is in fact missing. I think not retrying on 404 is ok; if the file is there but we have other issues, it'll be a non-404 status.If we think this might have larger repercussions, I can retry on
BaseDownloadError
in most cases, and override that with justDownloadError
specifically for downloadingchain-of-trust.json{,.sig}
until we create those files across all 3 worker implementations.What do you think, @JohanLorenzo , @tomprince ?